rdblue commented on code in PR #5407:
URL: https://github.com/apache/iceberg/pull/5407#discussion_r984022625
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1628,6 +1800,121 @@ components:
- $ref: '#/components/schemas/OAuthClientCredentialsRequest'
- $ref: '#/components/schemas/OAuthTokenExchangeRequest'
+ CounterResult:
+ type: object
+ required:
+ - unit
+ - value
+ properties:
+ unit:
+ type: string
+ value:
+ type: integer
+ format: int64
+
+ TimerResult:
+ type: object
+ required:
+ - time-unit
+ - count
+ - total-duration
+ properties:
+ time-unit:
+ type: string
+ count:
+ type: integer
+ format: int64
+ total-duration:
+ type: integer
+ format: int64
+
+ MetricResult:
+ anyOf:
+ - $ref: '#/components/schemas/CounterResult'
+ - $ref: '#/components/schemas/TimerResult'
+
+ Metrics:
+ type: object
+ additionalProperties:
+ $ref: '#/components/schemas/MetricResult'
+
+ ReportMetricsRequest:
+ type: object
+ required:
+ - report-type
+ - report
+ properties:
+ report-type:
+ type: string
+ report:
Review Comment:
I mentioned this before, but I think this should send the report information
here, rather than using an additional layer. That's what we do for similar
cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
