hendrikmakait commented on issue #5924: URL: https://github.com/apache/iceberg/issues/5924#issuecomment-1269496873
I'm concerned about the introduction of ambiguity to the `__repr__` with this change. Namely, the `__repr__` of both a `DoubleLiteral(1.0)` and a `FloatLiteral(1.0)` would become `literal(1.0)`, which in turn evaluates to a `DoubleLiteral(1.0)`. Hence, the `__repr__` becomes ambiguous with respect to the class of the original object and it will not recreate the same object for the case of the `FloatLiteral`. A similar situation occurs for `BinaryLiteral` and `FixedLiteral`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
