rdblue commented on code in PR #5926:
URL: https://github.com/apache/iceberg/pull/5926#discussion_r989431779
##########
api/src/main/java/org/apache/iceberg/expressions/ManifestEvaluator.java:
##########
@@ -399,18 +406,5 @@ public <T> Boolean notStartsWith(BoundReference<T> ref,
Literal<T> lit) {
return ROWS_MIGHT_MATCH;
}
-
- private boolean allValuesAreNull(PartitionFieldSummary summary,
Type.TypeID typeId) {
Review Comment:
I think I'd still prefer to keep this as a separate function, rather than
possibly recreating it (incorrectly) later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
