rdblue commented on code in PR #5893: URL: https://github.com/apache/iceberg/pull/5893#discussion_r989553026
########## core/src/test/java/org/apache/iceberg/TestManifestWriterVersions.java: ########## @@ -22,6 +22,8 @@ import java.io.IOException; import java.util.List; +import java.util.Map; +import org.apache.iceberg.avro.AvroIterable; Review Comment: What is the purpose of the updates here? I can understand testing that the manifest is written with a certain codec, but that should be in `TestManifestWriter` right? This tests different versions, which doesn't have much to do with the compression codec. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
