amogh-jahagirdar commented on code in PR #5669:
URL: https://github.com/apache/iceberg/pull/5669#discussion_r990675522
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -555,8 +575,9 @@ public void testRetainLastKeepsExpiringSnapshot() {
}
// Retain last 2 snapshots and expire older than t3
- table
- .expireSnapshots()
+ RemoveSnapshots removeSnapshots = (RemoveSnapshots)
table.expireSnapshots();
+ removeSnapshots
+ .withIncrementalCleanup(incrementalCleanup)
Review Comment:
Oversight, fixed!
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -602,8 +623,9 @@ public void testExpireOlderThanMultipleCalls() {
}
// Retain last 2 snapshots and expire older than t3
- table
- .expireSnapshots()
+ RemoveSnapshots removeSnapshots = (RemoveSnapshots)
table.expireSnapshots();
+ removeSnapshots
+ .withIncrementalCleanup(incrementalCleanup)
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
