aokolnychyi commented on PR #5934: URL: https://github.com/apache/iceberg/pull/5934#issuecomment-1272426670
@shardulm94, I refactored `SparkScan` (logical representation) and `SparkBatch` (physical representation) into multiple classes some time back but that caused a performance regression as we did not implement proper equality for `SparkBatch`. Then we reverted that change in PR #5143 to avoid the performance issue. This PR changes it back and overrides equality in `SparkBatch` so that everything works as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
