rdblue commented on code in PR #5872:
URL: https://github.com/apache/iceberg/pull/5872#discussion_r990819345
##########
api/src/main/java/org/apache/iceberg/expressions/ExpressionVisitors.java:
##########
@@ -55,6 +55,14 @@ public <T> R predicate(BoundPredicate<T> pred) {
public <T> R predicate(UnboundPredicate<T> pred) {
return null;
}
+
+ public <T> R aggregate(BoundAggregate<T> agg) {
+ return null;
Review Comment:
Is it safe to return `null` for all visitors that may have an `Aggregate`
passed in through `Expression`?
I think we may want to throw `UnsupportedOperationException` to ensure that
aggregates are either explicitly supported or will be rejected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
