Fokko commented on code in PR #5957:
URL: https://github.com/apache/iceberg/pull/5957#discussion_r993039124


##########
python/pyiceberg/catalog/__init__.py:
##########
@@ -97,7 +98,9 @@ def load_catalog(name: str, **properties: str | None) -> 
Catalog:
         if inferred_catalog_type := infer_catalog_type(conf):
             catalog_type = inferred_catalog_type
         else:
-            raise ValueError(f"Invalid configuration. Could not determine the 
catalog type: {properties}")
+            raise ValueError(
+                f"URI missing, please provide using --uri, the config or 
environment variable PYICEBERG_CATALOG__{name.upper()}__URI"

Review Comment:
   I've moved them to the `infer_catalog_type`, I think they make more sense 
there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to