rdblue commented on code in PR #5981:
URL: https://github.com/apache/iceberg/pull/5981#discussion_r996531195
##########
core/src/main/java/org/apache/iceberg/ReachableFileCleanup.java:
##########
@@ -64,18 +64,11 @@ public void cleanFiles(TableMetadata beforeExpiration,
TableMetadata afterExpira
}
}
- Set<ManifestFile> candidateManifestFilesForDeletion =
readManifests(expiredSnapshots);
- Set<ManifestFile> manifestFilesAfterExpiration =
readManifests(snapshotsAfterExpiration);
+ Set<ManifestFile> manifestsToDelete =
readManifests(snapshotsBeforeExpiration);
Review Comment:
Why does this use `snapshotsBeforeExpiration` rather than
`expiredSnapshots`? I think the ones referenced by expired snapshots are the
only possible manifests to delete, and having a smaller initial set may save
some work later if the new logic can short circuit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
