hililiwei commented on code in PR #6006:
URL: https://github.com/apache/iceberg/pull/6006#discussion_r998297182
##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -332,6 +332,8 @@ private TableProperties() {}
public static final String MERGE_MODE = "write.merge.mode";
public static final String MERGE_MODE_DEFAULT = "copy-on-write";
+ public static final String COPY_ON_WRITE_MODE = "copy-on-write";
+ public static final String MERGE_ON_READ_MODE = "merge-on-read";
Review Comment:
Yes, I did overlook that. I initially suggested a different name because
adding them individually to TableProperties felt a little weird.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
