rdblue commented on code in PR #6051:
URL: https://github.com/apache/iceberg/pull/6051#discussion_r1004615802
##########
core/src/main/java/org/apache/iceberg/util/JsonUtil.java:
##########
@@ -212,8 +212,7 @@ public static List<String> getStringList(String property,
JsonNode node) {
}
public static Set<String> getStringSet(String property, JsonNode node) {
- Preconditions.checkArgument(
- node.hasNonNull(property), "Cannot parse missing set: %s", property);
+ Preconditions.checkArgument(node.has(property), "Cannot parse missing set:
%s", property);
Review Comment:
Why relax the constraint? I think it would be safe to do this because of the
`isNull` check in the array handler, but I see no reason to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
