stevenzwu commented on code in PR #6049:
URL: https://github.com/apache/iceberg/pull/6049#discussion_r1004684887
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkConfParser.java:
##########
@@ -139,7 +139,6 @@ public StringConfParser defaultValue(String value) {
}
public String parse() {
- Preconditions.checkArgument(defaultValue != null, "Default value cannot
be null");
Review Comment:
why do we remove this line? My understanding of code is that `parseOptional`
should be used if default can be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
