aokolnychyi commented on code in PR #6002:
URL: https://github.com/apache/iceberg/pull/6002#discussion_r1006183172
##########
core/src/test/java/org/apache/iceberg/TestFastAppend.java:
##########
@@ -114,12 +114,14 @@ public void testEmptyTableAppendFilesAndManifest() throws
IOException {
validateManifest(
snap.allManifests(FILE_IO).get(0),
- seqs(1, 1),
+ seqs(1L, 1L), // data sequence numbers
Review Comment:
Done.
##########
format/spec.md:
##########
@@ -530,23 +532,23 @@ A manifest list is a valid Iceberg data file: files must
use valid Iceberg forma
Manifest list files store `manifest_file`, a struct with the following fields:
-| v1 | v2 | Field id, name | Type
| Description |
-| ---------- | ----------
|--------------------------------|---------------------------------------------|-------------|
-| _required_ | _required_ | **`500 manifest_path`** | `string`
| Location of the manifest file |
-| _required_ | _required_ | **`501 manifest_length`** | `long`
| Length of the manifest file in bytes |
-| _required_ | _required_ | **`502 partition_spec_id`** | `int`
| ID of a partition spec used to write the manifest;
must be listed in table metadata `partition-specs` |
-| | _required_ | **`517 content`** | `int` with
meaning: `0: data`, `1: deletes` | The type of files tracked by the manifest,
either data or delete files; 0 for all v1 manifests |
-| | _required_ | **`515 sequence_number`** | `long`
| The sequence number when the manifest was added to
the table; use 0 when reading v1 manifest lists |
-| | _required_ | **`516 min_sequence_number`** | `long`
| The minimum sequence number of all live data or
delete files in the manifest; use 0 when reading v1 manifest lists |
-| _required_ | _required_ | **`503 added_snapshot_id`** | `long`
| ID of the snapshot where the manifest file was
added |
-| _optional_ | _required_ | **`504 added_files_count`** | `int`
| Number of entries in the manifest that have status
`ADDED` (1), when `null` this is assumed to be non-zero |
-| _optional_ | _required_ | **`505 existing_files_count`** | `int`
| Number of entries in the manifest that have status
`EXISTING` (0), when `null` this is assumed to be non-zero |
-| _optional_ | _required_ | **`506 deleted_files_count`** | `int`
| Number of entries in the manifest that have status
`DELETED` (2), when `null` this is assumed to be non-zero |
-| _optional_ | _required_ | **`512 added_rows_count`** | `long`
| Number of rows in all of files in the manifest that
have status `ADDED`, when `null` this is assumed to be non-zero |
-| _optional_ | _required_ | **`513 existing_rows_count`** | `long`
| Number of rows in all of files in the manifest that
have status `EXISTING`, when `null` this is assumed to be non-zero |
-| _optional_ | _required_ | **`514 deleted_rows_count`** | `long`
| Number of rows in all of files in the manifest that
have status `DELETED`, when `null` this is assumed to be non-zero |
+| v1 | v2 | Field id, name | Type
| Description
|
+| ---------- | ----------
|--------------------------------|---------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------|
+| _required_ | _required_ | **`500 manifest_path`** | `string`
| Location of the manifest file
|
+| _required_ | _required_ | **`501 manifest_length`** | `long`
| Length of the manifest file in bytes
|
+| _required_ | _required_ | **`502 partition_spec_id`** | `int`
| ID of a partition spec used to write the manifest;
must be listed in table metadata `partition-specs`
|
+| | _required_ | **`517 content`** | `int` with
meaning: `0: data`, `1: deletes` | The type of files tracked by the manifest,
either data or delete files; 0 for all v1 manifests
|
+| | _required_ | **`515 sequence_number`** | `long`
| The sequence number when the manifest was added to
the table; use 0 when reading v1 manifest lists
|
+| | _required_ | **`516 min_sequence_number`** | `long`
| The minimum data sequence number of all live data
or delete files in the manifest; use 0 when reading v1 manifest lists
|
+| _required_ | _required_ | **`503 added_snapshot_id`** | `long`
| ID of the snapshot where the manifest file was
added
|
+| _optional_ | _required_ | **`504 added_files_count`** | `int`
| Number of entries in the manifest that have status
`ADDED` (1), when `null` this is assumed to be non-zero
|
+| _optional_ | _required_ | **`505 existing_files_count`** | `int`
| Number of entries in the manifest that have status
`EXISTING` (0), when `null` this is assumed to be non-zero
|
+| _optional_ | _required_ | **`506 deleted_files_count`** | `int`
| Number of entries in the manifest that have status
`DELETED` (2), when `null` this is assumed to be non-zero
|
+| _optional_ | _required_ | **`512 added_rows_count`** | `long`
| Number of rows in all of files in the manifest that
have status `ADDED`, when `null` this is assumed to be non-zero
|
+| _optional_ | _required_ | **`513 existing_rows_count`** | `long`
| Number of rows in all of files in the manifest that
have status `EXISTING`, when `null` this is assumed to be non-zero
|
+| _optional_ | _required_ | **`514 deleted_rows_count`** | `long`
| Number of rows in all of files in the manifest that
have status `DELETED`, when `null` this is assumed to be non-zero
|
| _optional_ | _optional_ | **`507 partitions`** | `list<508:
field_summary>` (see below) | A list of field summaries for each partition
field in the spec. Each field in the list corresponds to a field in the
manifest file’s partition spec. |
-| _optional_ | _optional_ | **`519 key_metadata`** | `binary`
| Implementation-specific key metadata for encryption
|
+| _optional_ | _optional_ | **`519 key_metadata`** | `binary`
| Implementation-specific key metadata for encryption
|
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
