szehon-ho commented on code in PR #5632:
URL: https://github.com/apache/iceberg/pull/5632#discussion_r1008565020
##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -101,20 +100,32 @@ private String fileClass() {
protected ManifestReader(
InputFile file,
+ int specId,
Map<Integer, PartitionSpec> specsById,
InheritableMetadata inheritableMetadata,
FileType content) {
this.file = file;
this.inheritableMetadata = inheritableMetadata;
this.content = content;
+ if (specsById != null) {
+ this.spec = specsById.get(specId);
+ } else {
+ this.spec = readPartitionSpec(file);
+ }
+
+ this.fileSchema = new
Schema(DataFile.getType(spec.partitionType()).fields());
+ }
+
+ private <T extends ContentFile<T>> PartitionSpec readPartitionSpec(InputFile
inputFile) {
+ Map<String, String> metadata;
try {
Review Comment:
Interesting, noticed there looks duplicate layer of try-finally, but guess
it's there before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
