dhruv-pratap commented on code in PR #6069:
URL: https://github.com/apache/iceberg/pull/6069#discussion_r1009566930
##########
python/pyiceberg/table/__init__.py:
##########
@@ -60,33 +60,40 @@ def sort_order(self) -> SortOrder:
sort_order for sort_order in self.metadata.sort_orders if
sort_order.order_id == self.metadata.default_sort_order_id
)
- def sort_orders(self) -> Dict[int, SortOrder]:
+ def sort_orders(self) -> dict[int, SortOrder]:
"""Return a dict of the sort orders of this table"""
return {sort_order.order_id: sort_order for sort_order in
self.metadata.sort_orders}
def location(self) -> str:
"""Return the table's base location."""
return self.metadata.location
- def current_snapshot(self) -> Optional[Snapshot]:
+ def current_snapshot(self) -> Snapshot | None:
"""Get the current snapshot for this table, or None if there is no
current snapshot."""
if snapshot_id := self.metadata.current_snapshot_id:
return self.snapshot_by_id(snapshot_id)
return None
- def snapshot_by_id(self, snapshot_id: int) -> Optional[Snapshot]:
+ def snapshot_by_id(self, snapshot_id: int) -> Snapshot | None:
"""Get the snapshot of this table with the given id, or None if there
is no matching snapshot."""
try:
return next(snapshot for snapshot in self.metadata.snapshots if
snapshot.snapshot_id == snapshot_id)
except StopIteration:
return None
- def snapshot_by_name(self, name: str) -> Optional[Snapshot]:
+ def snapshot_by_name(self, name: str) -> Snapshot | None:
"""Returns the snapshot referenced by the given name or null if no
such reference exists."""
if ref := self.metadata.refs.get(name):
return self.snapshot_by_id(ref.snapshot_id)
return None
- def history(self) -> List[SnapshotLogEntry]:
+ def history(self) -> list[SnapshotLogEntry]:
"""Get the snapshot history of this table."""
return self.metadata.snapshot_log
+
+ def new_scan(self, io: FileIO, snapshot_id: int | None = None, expression:
BooleanExpression | None = None):
+ """Create a new scan for this table."""
+ from pyiceberg.table.scan import DataTableScan
+
+ snapshot = self.snapshot_by_id(snapshot_id) if snapshot_id is not None
else None
Review Comment:
That does make sense. Will amend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
