szehon-ho commented on code in PR #6025: URL: https://github.com/apache/iceberg/pull/6025#discussion_r1009973723
########## docs/spark-procedures.md: ########## @@ -421,12 +421,17 @@ Existing data files are added to the Iceberg table's metadata and can be read us To leave the original table intact while testing, use [`snapshot`](#snapshot) to create new temporary table that shares source data files and schema. +By default, the original table is retained with the name `table_BACKUP_`. You can also explicitly pass `drop_backup => true` +to drop the backup after migration finishes. + #### Usage | Argument Name | Required? | Type | Description | |---------------|-----------|------|-------------| | `table` | ✔️ | string | Name of the table to migrate | -| `properties` | ️ | map<string, string> | Properties for the new Iceberg table | +| `properties` | ️ | map<string, string> | Properties for the new Iceberg table | Review Comment: Do you have one space after the last | ? You can maybe just copy and paste from the previous version? ########## docs/spark-procedures.md: ########## @@ -421,12 +421,17 @@ Existing data files are added to the Iceberg table's metadata and can be read us To leave the original table intact while testing, use [`snapshot`](#snapshot) to create new temporary table that shares source data files and schema. +By default, the original table is retained with the name `table_BACKUP_`. You can also explicitly pass `drop_backup => true` Review Comment: Sorry i should have been more clear, can we remove the second sentence as well? (as its duplicated already in the flag description). As you already mention 'by default', I think the user will know to look below. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
