rdblue commented on code in PR #6139:
URL: https://github.com/apache/iceberg/pull/6139#discussion_r1022060104
##########
python/pyiceberg/expressions/visitors.py:
##########
@@ -60,32 +61,34 @@
PrimitiveType,
)
+B = TypeVar("B")
Review Comment:
This isn't necessarily a boolean expression, which is why we used the most
generic name, `T`. I could see using `R` for this if we need to separate the
types and this is the best way (i.e. the fewest code changes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
