rdblue commented on code in PR #6128:
URL: https://github.com/apache/iceberg/pull/6128#discussion_r1022137280
##########
python/pyiceberg/expressions/literals.py:
##########
@@ -346,6 +365,12 @@ class TimeLiteral(Literal[int]):
def __init__(self, value: int):
super().__init__(value, int)
+ def increment(self) -> TimeLiteral:
+ return TimeLiteral(self.value + 1)
Review Comment:
I don't think that we allow time literals in partition expressions, do we?
That seems weird because time literals are bounded between 0 and at the number
of microseconds in a day. I'd probably exclude this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
