rdblue commented on PR #6128: URL: https://github.com/apache/iceberg/pull/6128#issuecomment-1314580426
I think the only blockers are in the literals, where `TimeLiteral` should not implement the new methods and is also copy-pasted incorrectly, and there's an issue with decimal increment/decrement to fix (it should increment the underlying unscaled value). Otherwise, this looks pretty good. There are a few minor things as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
