Fokko commented on code in PR #6128:
URL: https://github.com/apache/iceberg/pull/6128#discussion_r1027353231
##########
python/tests/test_transforms.py:
##########
@@ -874,7 +874,7 @@ def
test_projection_truncate_long_literal_eq(bound_reference_long: BoundReferenc
def test_projection_truncate_long_literal_gt(bound_reference_long:
BoundReference) -> None:
assert TruncateTransform(2).project(
"name", BoundGreaterThan(term=bound_reference_long,
literal=DecimalLiteral(Decimal(19.25)))
- ) == GreaterThanOrEqual(term="name", literal=Decimal("20.24"))
+ ) == GreaterThanOrEqual(term="name", literal=Decimal("19.26"))
Review Comment:
I'm sorry, I don't understand the issue. It looks equivalent to the Java
implementation:
https://github.com/apache/iceberg/blob/master/api/src/main/java/org/apache/iceberg/transforms/ProjectionUtil.java#L141-L145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
