nastra commented on code in PR #6242:
URL: https://github.com/apache/iceberg/pull/6242#discussion_r1029152726


##########
api/src/main/java/org/apache/iceberg/transforms/Identity.java:
##########
@@ -105,6 +142,21 @@ public boolean isIdentity() {
     return true;
   }
 
+  @Override
+  public boolean equals(Object o) {

Review Comment:
   I think it would be good to add a TODO here so that we don't forget to also 
remove `equals()` + `hashCode()` when removing the other deprecated methods



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to