rdblue commented on code in PR #6072:
URL: https://github.com/apache/iceberg/pull/6072#discussion_r1029941914


##########
core/src/main/java/org/apache/iceberg/IncrementalDataTableScan.java:
##########
@@ -105,6 +105,7 @@ public CloseableIterable<FileScanTask> planFiles() {
                     snapshotIds.contains(manifestEntry.snapshotId())
                         && manifestEntry.status() == 
ManifestEntry.Status.ADDED)
             .specsById(table().specs())
+            .scanMetrics(scanMetrics())

Review Comment:
   At some point, we should check whether we can rewrite this using the 
incremental scan API so that we don't have to maintain two implementations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to