gaborkaszab commented on PR #5837: URL: https://github.com/apache/iceberg/pull/5837#issuecomment-1327480362
Quick update: I have a PoC for the new MultiDimensionCounter<T> type. There are some rough edges but apart from the Json conversions seems to work fine. The from-Json part is a bit tricky because the code has to be aware what the generic parameter type is for the multi-dimensional counter so I had to also write this info into Json and use reflection to recreate the type. Apart from this the ScanReportParser and ScanMetricsResultParser tests fail because the order of the Json elements seems to matter for the asserts but the order of the elements in the multi-dimensional counter is not guaranteed. Working on fixing these and I'll upload new patch. This is where I'm now: https://github.com/gaborkaszab/iceberg/commit/b268f65f3d588f30c637aa3db3f53be2a5f4c80d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
