rdblue commented on code in PR #6217:
URL: https://github.com/apache/iceberg/pull/6217#discussion_r1032633740
##########
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##########
@@ -414,16 +414,20 @@ private void deleteRemovedMetadataFiles(TableMetadata
base, TableMetadata metada
TableProperties.METADATA_DELETE_AFTER_COMMIT_ENABLED_DEFAULT);
if (deleteAfterCommit) {
- Set<TableMetadata.MetadataLogEntry> removedPreviousMetadataFiles =
- Sets.newHashSet(base.previousFiles());
- removedPreviousMetadataFiles.removeAll(metadata.previousFiles());
- Tasks.foreach(removedPreviousMetadataFiles)
+ Set<TableMetadata.MetadataLogEntry> filesToDelete =
Sets.newHashSet(base.previousFiles());
Review Comment:
It doesn't look like there are behavior changes in this commit, just
variable renames? While I like better variable names, we don't want to
introduce code churn just to rename things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
