rdblue commented on code in PR #6247:
URL: https://github.com/apache/iceberg/pull/6247#discussion_r1032836474
##########
python/tests/expressions/test_visitors.py:
##########
@@ -1429,3 +1432,162 @@ def test_rewrite_bound():
accessor=Accessor(position=0, inner=None),
)
)
+
+
[email protected]
+def spec() -> PartitionSpec:
+ return PartitionSpec(PartitionField(1, 1000, IdentityTransform(), "id"))
+
+
+def test_identity_projection(schema: Schema, spec: PartitionSpec):
+ predicates = [
+ NotNull("id"),
+ IsNull("id"),
+ LessThan("id", 100),
+ LessThanOrEqual("id", 101),
+ GreaterThan("id", 102),
+ GreaterThanOrEqual("id", 103),
+ EqualTo("id", 104),
+ NotEqualTo("id", 105),
+ ]
+
+ expected = [
+ BoundNotNull(
+ term=BoundReference[int](
+ field=NestedField(field_id=1000, name="id",
field_type=IntegerType(), required=False),
+ accessor=Accessor(position=0, inner=None),
+ )
+ ),
+ BoundIsNull(
+ term=BoundReference[int](
+ field=NestedField(field_id=1000, name="id",
field_type=IntegerType(), required=False),
+ accessor=Accessor(position=0, inner=None),
+ )
+ ),
+ BoundLessThan(
+ term=BoundReference[int](
+ field=NestedField(field_id=1000, name="id",
field_type=IntegerType(), required=False),
+ accessor=Accessor(position=0, inner=None),
+ ),
+ literal=literal(100),
+ ),
+ BoundLessThanOrEqual(
+ term=BoundReference[int](
+ field=NestedField(field_id=1000, name="id",
field_type=IntegerType(), required=False),
+ accessor=Accessor(position=0, inner=None),
+ ),
+ literal=literal(101),
+ ),
+ BoundGreaterThan(
+ term=BoundReference[int](
+ field=NestedField(field_id=1000, name="id",
field_type=IntegerType(), required=False),
+ accessor=Accessor(position=0, inner=None),
+ ),
+ literal=literal(102),
+ ),
+ BoundGreaterThanOrEqual(
+ term=BoundReference[int](
+ field=NestedField(field_id=1000, name="id",
field_type=IntegerType(), required=False),
+ accessor=Accessor(position=0, inner=None),
+ ),
+ literal=literal(103),
+ ),
+ BoundEqualTo(
+ term=BoundReference[int](
+ field=NestedField(field_id=1000, name="id",
field_type=IntegerType(), required=False),
+ accessor=Accessor(position=0, inner=None),
+ ),
+ literal=literal(104),
+ ),
+ BoundNotEqualTo(
+ term=BoundReference[int](
+ field=NestedField(field_id=1000, name="id",
field_type=IntegerType(), required=False),
+ accessor=Accessor(position=0, inner=None),
+ ),
+ literal=literal(105),
+ ),
+ ]
+
+ for idx in range(len(predicates)):
+ expr = inclusive_projection(predicates[idx], schema, spec)
+ assert expr == expected[idx]
+
+
+def test_identity_projection_ignore_casing(schema: Schema, spec:
PartitionSpec):
Review Comment:
This could use a few more test cases:
* One with each transform
* At least one `And` where one child can be projected and the other cannot
* At least one `Or` where one child can be projected and the other cannot
* At least one with `Not` that gets rewritten
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
