nastra commented on code in PR #6217:
URL: https://github.com/apache/iceberg/pull/6217#discussion_r1033294595
##########
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java:
##########
@@ -414,16 +414,20 @@ private void deleteRemovedMetadataFiles(TableMetadata
base, TableMetadata metada
TableProperties.METADATA_DELETE_AFTER_COMMIT_ENABLED_DEFAULT);
if (deleteAfterCommit) {
- Set<TableMetadata.MetadataLogEntry> removedPreviousMetadataFiles =
- Sets.newHashSet(base.previousFiles());
- removedPreviousMetadataFiles.removeAll(metadata.previousFiles());
- Tasks.foreach(removedPreviousMetadataFiles)
+ Set<TableMetadata.MetadataLogEntry> filesToDelete =
Sets.newHashSet(base.previousFiles());
Review Comment:
yes this was only a variable rename to make things a bit clearer to
understand when reading this part of the code as `removedPreviousMetadataFiles`
was a bit confusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
