nastra commented on PR #6168:
URL: https://github.com/apache/iceberg/pull/6168#issuecomment-1329273966
After we enabled RevAPI on `iceberg-core`, we've seen the following
RevAPI failures on all JSON Deserializer classes:
```
* Just this break:
./gradlew :iceberg-core:revapiAcceptBreak --justification "{why this
break is ok}" \
--code "java.method.exception.checkedAdded" \
--old "method java.lang.Object
com.fasterxml.jackson.databind.JsonDeserializer<T>::deserializeWithType(com.fasterxml.jackson.core.JsonParser,
com.fasterxml.jackson.databind.DeserializationContext,
com.fasterxml.jackson.databind.jsontype.TypeDeserializer, T) throws
java.io.IOException @
org.apache.iceberg.rest.RESTSerializers.UnboundPartitionSpecDeserializer" \
--new "method java.lang.Object
com.fasterxml.jackson.databind.JsonDeserializer<T>::deserializeWithType(com.fasterxml.jackson.core.JsonParser,
com.fasterxml.jackson.databind.DeserializationContext,
com.fasterxml.jackson.databind.jsontype.TypeDeserializer, T) throws
java.io.IOException, com.fasterxml.jackson.core.JacksonException @
org.apache.iceberg.rest.RESTSerializers.UnboundPartitionSpecDeserializer"
* All breaks in this project:
./gradlew :iceberg-core:revapiAcceptAllBreaks --justification "{why
this break is ok}"
* All breaks in all projects:
./gradlew revapiAcceptAllBreaks --justification "{why this break is
ok}"
----------------------------------------------------------------------------------------------------
java.method.exception.checkedAdded: Method newly throws checked
exceptions: com.fasterxml.jackson.core.JacksonException.
old: method T
com.fasterxml.jackson.databind.JsonDeserializer<T>::deserialize(com.fasterxml.jackson.core.JsonParser,
com.fasterxml.jackson.databind.DeserializationContext, T) throws
java.io.IOException @
org.apache.iceberg.rest.RESTSerializers.UnboundSortOrderDeserializer
new: method T
com.fasterxml.jackson.databind.JsonDeserializer<T>::deserialize(com.fasterxml.jackson.core.JsonParser,
com.fasterxml.jackson.databind.DeserializationContext, T) throws
java.io.IOException, com.fasterxml.jackson.core.JacksonException @
org.apache.iceberg.rest.RESTSerializers.UnboundSortOrderDeserializer
SOURCE: BREAKING, BINARY: NON_BREAKING
From old archive: iceberg-core-1.0.0.jar
From new archive: iceberg-core-dd5164b.jar
```
I've introduced `IcebergJsonDeserializer` with the old throws-signature
for all of our JSON Deserializers to resolve that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
