nastra commented on code in PR #6293:
URL: https://github.com/apache/iceberg/pull/6293#discussion_r1033681169
##########
orc/src/test/java/org/apache/iceberg/orc/TestOrcDataWriter.java:
##########
@@ -126,4 +135,125 @@ public void testDataWriter() throws IOException {
Assert.assertEquals("Written records should match", records,
writtenRecords);
}
+
+ @Test
+ public void testNoSupportForDummyScheme() throws IOException {
+ ProxyOutputFile outFile = new
ProxyOutputFile(Files.localOutput(temp.newFile()));
+ Assertions.assertThrows(
+ RuntimeIOException.class,
+ () -> HadoopOutputFile.fromPath(new Path(outFile.location()), new
Configuration()),
+ "No FileSystem for scheme \"dummy\"");
+ }
+
+ @Test
+ public void testUsingFileIO() throws IOException {
+ // Show that FileSystem access is not possible for the file we are
supplying as the scheme
+ // dummy is not handled
+ ProxyOutputFile outFile = new
ProxyOutputFile(Files.localOutput(temp.newFile()));
+ Assertions.assertThrows(
Review Comment:
it would be better to move such assertions to AssertJ, because otherwise
it'll be more work potentially to move such code when upgrading to Junit5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
