nastra commented on code in PR #6274:
URL: https://github.com/apache/iceberg/pull/6274#discussion_r1036817726
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/data/TestSparkParquetReader.java:
##########
@@ -144,16 +143,16 @@ public void
testInt96TimestampProducedBySparkIsReadCorrectly() throws IOExceptio
});
List<InternalRow> rows =
Lists.newArrayList(RandomData.generateSpark(schema, 10, 0L));
- try (FileAppender<InternalRow> writer =
- new ParquetWriteAdapter<>(
- new NativeSparkWriterBuilder(outputFile)
- .set("org.apache.spark.sql.parquet.row.attributes",
sparkSchema.json())
- .set("spark.sql.parquet.writeLegacyFormat", "false")
- .set("spark.sql.parquet.outputTimestampType", "INT96")
- .set("spark.sql.parquet.fieldId.write.enabled", "true")
- .build(),
- MetricsConfig.getDefault())) {
- writer.addAll(rows);
+ try (ParquetWriter<InternalRow> writer =
Review Comment:
this was using the deprecated `ParquetWriteAdapter` class, so I started
changing code that uses this class so that we can eventually remove
`ParquetWriteAdapter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
