aokolnychyi commented on code in PR #6345:
URL: https://github.com/apache/iceberg/pull/6345#discussion_r1037689362
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkChangelogScan.java:
##########
@@ -103,8 +104,7 @@ public StructType readSchema() {
@Override
public Batch toBatch() {
- return new SparkChangelogBatch(
- spark, table, readConf, taskGroups(), expectedSchema, hashCode());
+ return new SparkBatch(sparkContext, table, readConf, taskGroups(),
expectedSchema, hashCode());
Review Comment:
If you take a look at `SparkChangelogBatch`, it was identical to
`SparkBatch`, except the reader factory. Since we are adding a common factory
for all tasks, it seemed appropriate to always leverage `SparkBatch`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
