[GitHub] [iceberg] RussellSpitzer commented on a diff in pull request #6376: Docs: Add register table Spark procedure documentation

[GitBox]

RussellSpitzer commented on code in PR #6376:
URL: https://github.com/apache/iceberg/pull/6376#discussion_r1043593616


##########
docs/spark-procedures.md:
##########
@@ -493,6 +493,39 @@ CALL spark_catalog.system.add_files(
 )
 ```
 
+### `register_table`
+
+Creates a catalog entry for a metadata.json file which already exists but does 
not have a corresponding catalog identifier.
+
+#### Usage
+
+| Argument Name | Required? | Type | Description |
+|---------------|-----------|------|-------------|
+| `table`       | ✔️  | string | Table which is to be registered |
+| `metadata_file`| ✔️  | string | Metadata file which is to be registered as a 
new catalog identifier |
+
+{{< hint warning >}}

Review Comment:
   I'm not familiar with this syntax, I believe we do ```!!! Warning```
   
   Like
   
   ```
   !!! Warning
       Spark 3.0.0 has a correctness bug that affects dynamic `INSERT 
OVERWRITE` with hidden partitioning, [SPARK-32168][spark-32168].
       For tables with [hidden partitions](./partitioning.md), make sure you 
use Spark 3.0.1.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org