rdblue commented on code in PR #6074:
URL: https://github.com/apache/iceberg/pull/6074#discussion_r1044672058
##########
core/src/main/java/org/apache/iceberg/SnapshotManager.java:
##########
@@ -30,6 +31,17 @@ public class SnapshotManager implements ManageSnapshots {
ops.current() != null, "Cannot manage snapshots: table %s does not
exist", tableName);
this.transaction =
new BaseTransaction(tableName, ops,
BaseTransaction.TransactionType.SIMPLE, ops.refresh());
+ this.isExternalTransaction = false;
+ }
+
+ SnapshotManager(BaseTransaction transaction) {
+ Preconditions.checkNotNull(transaction, "Input transaction cannot be
null");
+ Preconditions.checkNotNull(
Review Comment:
In what case does this matter? Shouldn't you be able to start a create
transaction, add a couple of commits, and then use this class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
