szehon-ho commented on code in PR #6344:
URL: https://github.com/apache/iceberg/pull/6344#discussion_r1044799711
##########
api/src/main/java/org/apache/iceberg/ChangelogOperation.java:
##########
@@ -21,5 +21,7 @@
/** An enum representing possible operations in a changelog. */
public enum ChangelogOperation {
INSERT,
- DELETE
+ DELETE,
+ UPDATE_BEFORE,
Review Comment:
Just curious, are we still going with "PRE_UPDATE" , "POST_UPDATE" as design
doc?
https://docs.google.com/document/d/1bN6rdLNcYOHnT3xVBfB33BoiPO06aKBo56SZmuU9pnY/edit#heading=h.czd6l3c9xj87
At least I think having the adjective before "Update" is better. Not sure
if I missed some other discussion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
