rdblue commented on code in PR #6072:
URL: https://github.com/apache/iceberg/pull/6072#discussion_r1044896209
##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -118,6 +119,10 @@ public static Set<Integer> getProjectedIds(Schema schema) {
return ImmutableSet.copyOf(getIdsInternal(schema.asStruct(), true));
}
+ public static List<String> getProjectedFieldNames(Schema schema,
Iterable<Integer> projectedIds) {
Review Comment:
Style: use of `get` in a method name is discouraged. It's usually not
helping or could be replaced with a more specific verb like `find` or `build`.
Here, I'd just omit it.
Also, I think this name is a bit too specific since there's no reason why
you must pass "projected" IDs here. This could just be
`resolveFieldNames(Schema, Iterable<Integer>)`. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
