nastra commented on code in PR #6404:
URL: https://github.com/apache/iceberg/pull/6404#discussion_r1045949398
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -304,7 +306,9 @@ public Table loadTable(SessionContext context,
TableIdentifier identifier) {
new BaseTable(
ops,
fullTableName(loadedIdent),
- report -> reportMetrics(tableIdentifier, report,
session::headers));
Review Comment:
> like being able to set this even after the Catalog is up and running
I'm not sure this is want we want. I would probably say it's better/easier
to just re-configure/re-build the catalog with a different metrics reporter.
This is what we do across other catalog properties as well.
> have the ability to use different MetricsReporter implementation for
different tables.
I don't think the UX will be great in such a case where a user would have to
re-configure the metrics reporter per table. I think if we'd want to support
something like that, then we'd need a strong use case that justifies this.
This is just my personal opinion, but I'm happy to hear what others think on
that topic. If there's enough interest/a strong use case then we can
re-evaluate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
