hililiwei commented on code in PR #6451:
URL: https://github.com/apache/iceberg/pull/6451#discussion_r1056353089


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -759,6 +816,40 @@ private static boolean hiveEngineEnabled(TableMetadata 
metadata, Configuration c
         ConfigProperties.ENGINE_HIVE_ENABLED, 
TableProperties.ENGINE_HIVE_ENABLED_DEFAULT);
   }
 
+  private Pair<Long, LockState> findLock(String agentInfo) throws TException, 
InterruptedException {
+    // Search for the locks using HMSClient.showLocks identified by the 
agentInfo
+    ShowLocksRequest showLocksRequest = new ShowLocksRequest();
+    showLocksRequest.setDbname(database);
+    showLocksRequest.setTablename(tableName);
+    ShowLocksResponse response = metaClients.run(client -> 
client.showLocks(showLocksRequest));
+    for (ShowLocksResponseElement lock : response.getLocks()) {

Review Comment:
   Not familiar with this. But excuse, is it possible to have multiple 
agentInfo locked in it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to