JonasJ-ap commented on code in PR #6449:
URL: https://github.com/apache/iceberg/pull/6449#discussion_r1056753664
##########
data/src/main/java/org/apache/iceberg/data/TableMigrationUtil.java:
##########
@@ -161,7 +161,7 @@ private static Metrics getAvroMetrics(Path path,
Configuration conf) {
}
}
- private static Metrics getParquetMetrics(
+ public static Metrics getParquetMetrics(
Review Comment:
Thank you for your suggestion. I've migrate these functions to a new class
called `FileMetricsReader` in `iceberg-delta-lake`. It seems doing so just
involves copy-pase the `getParquetMetrics` from `TableMigrationUtil` to
`FileMetricsReader`. Do we need to worry about the duplicated code here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
