zhongyujiang commented on code in PR #6517:
URL: https://github.com/apache/iceberg/pull/6517#discussion_r1061447313
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java:
##########
@@ -580,6 +608,10 @@ static boolean hasNonNullButNoMinMax(Statistics
statistics, long valueCount) {
&& (statistics.getMaxBytes() == null || statistics.getMinBytes() ==
null);
}
+ static boolean minMaxUndefined(Statistics statistics) {
+ return !statistics.isEmpty() && !statistics.hasNonNullValue();
Review Comment:
This [unit
test](https://github.com/apache/iceberg/actions/runs/3832299279/jobs/6522446976#step:6:272)
fails, I think it's because when all values are all null , min max will be
null(undefined) too, seems we should handle the case of all values first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
