nastra commented on issue #6510: URL: https://github.com/apache/iceberg/issues/6510#issuecomment-1375859259
I've checked the code and it looks like we have a test that does something similar. Looking at https://github.com/apache/iceberg/blob/master/arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java#L911-L912 one can see that we're using a `LocalDateTimeToLongMicros` helper class that does some additional checking for `LocalDateTime` / `OffsetDateTime` stuff: https://github.com/apache/iceberg/blob/master/arrow/src/test/java/org/apache/iceberg/arrow/vectorized/ArrowReaderTest.java#L1215-L1250. @rdblue I wonder whether we should add this additional checking for `LocalDateTime` / `OffsetDateTime` to `GenericRecord.get()`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
