jackye1995 commented on code in PR #6449: URL: https://github.com/apache/iceberg/pull/6449#discussion_r1064315745
########## delta-lake/src/main/java/org/apache/iceberg/delta/SupportSnapshotFromDeltaLake.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.delta; + +/** + * An API that should be implemented by query engine integrations that want to support snapshotting + * from Delta Lake table to Iceberg table. + */ +public interface SupportSnapshotFromDeltaLake { + + /** Initiates an action to migrate an existing Delta Lake table to Iceberg. */ + default SnapshotDeltaLakeTable migrateDeltaLakeTable(String tableIdent, String deltaS3Location) { Review Comment: 1. as said in the previous comment, this should probably be `snapshotDeltaLakeTable`. 2. for the arguments of the method, we can consult the `ActionsProvider` interface, I think we only need 1 input which is `String sourceTableLocation` 3. we can offer a default implementation for the interface, which is to return the Base class you implemented With those 3, we can have something like the following as the final user experience (suppose we have a new class `DefaultDeltaLakeToIcebergMigrationActionsProvider ` implements `DeltaLakeToIcebergMigrationActionsProvider ` and offer the base implementations: ``` DeltaLakeToIcebergMigrationActionsProvider.default().snapshotDeltaLakeTable("s3://some/path/to/delta") .as(TableIdentifier.of("db", "table")) .deltaLakeConfiguration(....) .icebergCatalog(...) .tableProperties(...) .tableLocation(...) .execute(); ``` And with that, we don't need anything in the constructor of `BaseSnapshotDeltaLakeTableAction`, because everything are moved to the interface for user to chain the input. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
