flyrain commented on code in PR #6550:
URL: https://github.com/apache/iceberg/pull/6550#discussion_r1065225701
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/VectorizedSparkParquetReaders.java:
##########
@@ -75,6 +108,57 @@ public static ColumnarBatchReader buildReader(
deleteFilter));
}
+ public static ColumnarBatchReader buildReader(
+ Schema expectedSchema,
+ MessageType fileSchema,
+ Map<Integer, ?> idToConstant,
+ DeleteFilter<InternalRow> deleteFilter) {
+ return (ColumnarBatchReader)
+ TypeWithSchemaVisitor.visit(
+ expectedSchema.asStruct(),
+ fileSchema,
+ new ReaderBuilder(
+ expectedSchema,
+ fileSchema,
+ NullCheckingForGet.NULL_CHECKING_ENABLED,
Review Comment:
Minor point: Since we are going to read/write this system property
everywhere, I guess there is no point to pass around this parameter. Always
good to minimize the parameters. I'm OK to fix it or not though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
