ajantha-bhat commented on code in PR #6552:
URL: https://github.com/apache/iceberg/pull/6552#discussion_r1065340205
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/SnapshotTableSparkAction.java:
##########
@@ -174,7 +174,7 @@ protected Map<String, String> destTableProps() {
// make sure we mark this table as a snapshot table
properties.put(TableProperties.GC_ENABLED, "false");
Review Comment:
As `GC_ENABLED` is set to false (line 176) for this table created by
snapshot action, expire snapshots and remove_orphan files will anyways not
clean up the files. So, I am wondering why do we need one property that does
the same thing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
