nastra commented on code in PR #6489:
URL: https://github.com/apache/iceberg/pull/6489#discussion_r1065435914


##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java:
##########
@@ -101,6 +107,17 @@ public static Map<String, String> authHeaders(String 
token) {
     }
   }
 
+  public static Map<String, String> basicAuthHeader(String credential) {

Review Comment:
   I've adjusted this to be plural to be in line with `authHeaders` but it 
feels weird that those are plural, since technically there's always only a 
single authorization header being added to the map



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to