rdblue commented on code in PR #6512:
URL: https://github.com/apache/iceberg/pull/6512#discussion_r1066006935
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -351,7 +354,30 @@ public void invalidateTable(SessionContext context,
TableIdentifier ident) {}
@Override
public Table registerTable(
SessionContext context, TableIdentifier ident, String
metadataFileLocation) {
- throw new UnsupportedOperationException("Register table is not supported");
+ checkIdentifierIsValid(ident);
+
+ Preconditions.checkArgument(
+ metadataFileLocation != null && !metadataFileLocation.isEmpty(),
+ "Cannot register an empty metadata file location as a table");
+
+ // Throw an exception if this table already exists in the catalog.
+ if (tableExists(context, ident)) {
+ throw new AlreadyExistsException("Table already exists: %s", ident);
+ }
+
+ TableMetadata metadata = TableMetadataParser.read(io,
metadataFileLocation);
+ Map<String, String> tableProperties =
+ ImmutableMap.<String, String>builder()
+ .putAll(metadata.properties())
+ .put(BaseMetastoreTableOperations.METADATA_LOCATION_PROP,
metadataFileLocation)
+ .build();
+
+ return buildTable(context, ident, metadata.schema())
+ .withLocation(metadata.location())
+ .withProperties(tableProperties)
+ .withPartitionSpec(metadata.spec())
+ .withSortOrder(metadata.sortOrder())
+ .create();
Review Comment:
This discards all table data and older schemas, specs, and sort orders. I
think this needs to preserve the table metadata completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
