jackye1995 commented on code in PR #6520: URL: https://github.com/apache/iceberg/pull/6520#discussion_r1066106055
########## format/view-spec.md: ########## @@ -118,6 +118,31 @@ This type of representation stores the original view definition in SQL and its S For `CREATE VIEW v (alias_name COMMENT 'docs', alias_name2, ...) AS SELECT col1, col2, ...`, the field aliases are 'alias_name', 'alias_name2', and etc., and the field docs are 'docs', null, and etc. +#### Atomic swap for File System Views Review Comment: I think that is written under the context of commit conflict resolution, and those are specific examples about how the commit resolution could be implemented as atomic swap in file system or metastore. But with introduction of REST catalogs that are backed by complicated services, there could be much more complex operations done during commit time. This makes me think if we should also update the table spec to make this clear that these are more like examples, but not specifications. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
