amogh-jahagirdar commented on code in PR #6559: URL: https://github.com/apache/iceberg/pull/6559#discussion_r1066524480
########## core/src/main/java/org/apache/iceberg/view/ViewMetadata.java: ########## @@ -0,0 +1,301 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.view; + +import java.io.Serializable; +import java.util.Comparator; +import java.util.List; +import java.util.Map; +import org.apache.iceberg.Schema; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; +import org.apache.iceberg.relocated.com.google.common.collect.Ordering; + +public class ViewMetadata implements Serializable { + static final int DEFAULT_VIEW_FORMAT_VERSION = 1; + static final int SUPPORTED_VIEW_FORMAT_VERSION = 1; + + // stored metadata + private final int formatVersion; + private final String location; + private final Map<String, String> properties; + private final int currentVersionId; + private final Integer currentSchemaId; + private final List<ViewVersion> versions; + private final Map<Integer, ViewVersion> versionsById; + private final List<ViewHistoryEntry> versionLog; + private final List<Schema> schemas; + private final Map<Integer, Schema> schemasById; + private final String metadataFileLocation; Review Comment: Shouldn't store metadataFileLocation, I'll fix this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
