kmozaid commented on code in PR #6410:
URL: https://github.com/apache/iceberg/pull/6410#discussion_r1067058918
##########
core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java:
##########
@@ -301,4 +305,16 @@ protected static String fullTableName(String catalogName,
TableIdentifier identi
return sb.toString();
}
+
+ private MetricsReporter metricsReporter() {
+ if (metricsReporter == null) {
+ metricsReporter =
+ properties().containsKey(CatalogProperties.METRICS_REPORTER_IMPL)
+ ? CatalogUtil.loadMetricsReporter(
+ properties().get(CatalogProperties.METRICS_REPORTER_IMPL))
+ : LoggingMetricsReporter.instance();
Review Comment:
HI @szehon-ho Even without this change, LoggingMetricsReporter is always
enabled for all catalogs...See BaseTable
https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/BaseTable.java#L45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
