pvary commented on code in PR #2639:
URL: https://github.com/apache/iceberg/pull/2639#discussion_r1071108598
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -231,6 +252,39 @@ private WriteBuilder createContextFunc(
return this;
}
+ private FileEncryptionProperties createEncryptionProperties(
+ NativeFileCryptoParameters nativeParameters) {
+ Preconditions.checkArgument(nativeParameters != null, "Null native
crypto parameters");
+
+ ParquetCipher parquetEncryptionAlgorithm;
+ if (nativeParameters.encryptionAlgorithm() == null) {
+ parquetEncryptionAlgorithm = ParquetCipher.AES_GCM_V1; // default
Review Comment:
Question: Do we want this default to be configurable? It is always strange
to hardcode these values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
