RussellSpitzer commented on issue #6604: URL: https://github.com/apache/iceberg/issues/6604#issuecomment-1384165741
Example tests https://github.com/apache/iceberg/blob/dbb8a404f6632a55acb36e949f0e7b84b643cede/spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/TestSparkDistributionAndOrderingUtil.java Application in write builder https://github.com/apache/iceberg/blob/8c6adf6e5e17603025d23b2012aa576c071ff269/spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java#L204-L276 Properties https://github.com/apache/iceberg/blob/8c6adf6e5e17603025d23b2012aa576c071ff269/core/src/main/java/org/apache/iceberg/TableProperties.java#L299-L302 https://github.com/apache/iceberg/blob/8c6adf6e5e17603025d23b2012aa576c071ff269/core/src/main/java/org/apache/iceberg/TableProperties.java#L322 https://github.com/apache/iceberg/blob/8c6adf6e5e17603025d23b2012aa576c071ff269/core/src/main/java/org/apache/iceberg/TableProperties.java#L330 https://github.com/apache/iceberg/blob/8c6adf6e5e17603025d23b2012aa576c071ff269/core/src/main/java/org/apache/iceberg/TableProperties.java#L351 We probably want to default all of these to something other than none. In 3.3 the adaptive skew handling is good enough to avoid most OOM issues, I think Hash is probably fine for every table that doesn't have a global ordering set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
