rdblue commented on code in PR #6634:
URL: https://github.com/apache/iceberg/pull/6634#discussion_r1084372467
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -395,9 +393,8 @@ private void commitSimpleTransaction() {
return;
}
- // this is always set to the latest commit attempt's snapshot id.
- AtomicLong currentSnapshotId = new AtomicLong(-1L);
-
+ Set<Long> preTxnSnapshots =
Review Comment:
We avoid using short names that are hard to type, like `txn`. It doesn't
save that much space and it makes the code harder to work with in general. I'd
recommend choosing a better word instead, like `existingSnapshots` or
`startingSnapshots`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
